On 29.01.21 12:06, Jan Beulich wrote:
Hi Jan, Julien
On 29.01.2021 10:55, Julien Grall wrote:
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -137,7 +137,13 @@ config HYPFS_CONFIG
want to hide the .config contents from dom0.
config IOREQ_SERVER
- bool
+ bool "IOREQ support (EXPERT)" if EXPERT && !X86
+ default X86
+ depends on HVM
AFAICT, CONFIG_HVM will already select CONFIG_IOREQ_SERVER. So are the
two lines necessary?
I agree they may not be necessary, but as long as they don't
cause any harm I thought maybe they serve a documentation
purpose.
1. Agree that it should be "If unsure, say N."
2. Agree that two lines are not strictly needed (just rechecked).
3. Agree that two lines indicates the *real* state:
- Although we managed to remove almost all (all?) HVM-ism in IOREQ
common code, this feature depends on HVM anyway
- And it is should enabled by default on X86, and disabled on Arm
So what we should do with them (keep or remove)?
Jan
--
Regards,
Oleksandr Tyshchenko
