On 02/02/2021 11:51, Ian Jackson wrote:
> Igor Druzhinin writes ("Re: staging: unable to restore HVM with Viridian
> param set"):
>> On 02/02/2021 08:35, Paul Durrant wrote:
>>> Surely it should be addressed properly in libxl by not messing with the
>>> viridian settings on migrate-in/resume, as Andrew says? TBH I thought this
>>> was already the case. There should be no problem with adding to the default
>>> set as this is just an xl/libxl concept; the param flags in Xen are always
>>> define the *exact* set of enabled enlightenments.
>> If maintainers agree with this approach I can make a patch.
> If Andy is in favour of this approach then certainly it is fine by me.
Yeah - in the case that we're restoring from a suspend image or migrate,
just skip setting the viridian flags in build. They are in the the
stream, and will be restored later.
~Andrew
P.S. This is going to get even more complicated when it all shifts into
CPUID settings, but it needs to happen at some point.
