Hi,

On 17/02/2021 23:23, Stefano Stabellini wrote:
+IanJ

On Wed, 17 Feb 2021, Bertrand Marquis wrote:
Hi Rahul,


On 17 Feb 2021, at 10:05, Rahul Singh <rahul.si...@arm.com> wrote:

SMMUv3 driver does not handle multiple StreamId if the master device
supports more than one StreamID.

This bug was introduced when the driver was ported from Linux to XEN.
dt_device_set_protected(..) should be called from add_device(..) not
from the dt_xlate(..).

Move dt_device_set_protected(..) from dt_xlate(..) to add_device().

Signed-off-by: Rahul Singh <rahul.si...@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com>

Thanks a lot, this is fixing issues with multiple stream ids for one device :-)

Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>


---
This patch is a candidate for 4.15 as without this patch it is not possible to
assign multiple StreamIds to the same device when device is protected behind
SMMUv3.

I agree especially considering that the impact is limited to smmu-v3.c.

SMMUv3 is in tech preview, so the risk is pretty low as we don't support it :).

But, a release ack from Ian is not necessary until tonight (19th February) for bug fixes. So I have committed the patch.

Cheers,

--
Julien Grall

Reply via email to