On 25/02/2021 17:41, Julien Grall wrote: > From: Julien Grall <jgr...@amazon.com> > > Coverity will report unitialized values for every use of xs_state_* > structures in the save part. This can be prevented by using the [0] > rather than [] to define variable length array. > > Coverity-ID: 1472398 > Coverity-ID: 1472397 > Coverity-ID: 1472396 > Coverity-ID: 1472395 > Signed-off-by: Julien Grall <jgr...@amazon.com> > > --- > > From my understanding, the tools and the hypervisor already rely on GNU > extensions. So the change should be fine. > > If not, we can use the same approach as XEN_FLEX_ARRAY_DIM.
Linux has recently purged the use of [0] because it causes sizeof() to do unsafe things. Flexible array members is a C99 standard - are we sure that Coverity is doing something wrong with them? ~Andrew
