On 05.03.2021 13:49, Andrew Cooper wrote: > Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. > > That change actually broke the build with: > > include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' > ioservid_t *id); > ^ > > as libxendevicemodel.h now uses a type it can't see a typedef for. However, > nothing noticed because the header.chk logic is also broken (fixed > subsequently).
While I agree up to here, ... > Strip the guard from the public header, and remove compensation from > devicemodel's private.h ... I'm unconvinced that entirely dropping the guard from the public header is wanted (or needed): We use these to make clear that in particular kernels aren't supposed to make use of the enclosed entities. If a type needs exposing, it (and only it) wants moving ou of the guarded region imo. Jan
