On 08.03.2021 14:59, Michal Orzel wrote: > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -68,7 +68,7 @@ extra-y += $(TARGET_SUBARCH)/head.o > > #obj-bin-y += ....o > > -ifdef CONFIG_DTB_FILE > +ifneq ($(CONFIG_DTB_FILE),"") > obj-y += dtb.o > AFLAGS-y += -DCONFIG_DTB_FILE=\"$(CONFIG_DTB_FILE)\" > endif
Right now what I have for my Arm test builds is an unquoted string in ./.config, e.g.: CONFIG_DTB_FILE:=/usr/local/arm-linux-gnueabi/vexpress-v2p-aem-v7a.dtb While I suppose you've tested that the resulting quoting is still okay, to reduce confusion perhaps the AFLAGS-y line would better be changed to AFLAGS-y += '-DCONFIG_DTB_FILE=$(CONFIG_DTB_FILE)' at the same time? Jan
