On 10/03/2021 15:14, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__
> header guard from public API"):
>> Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library.
>>
>> That change actually broke the build with:
>>
>> include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t'
>> ioservid_t *id);
>> ^
>>
>> as libxendevicemodel.h now uses a type it can't see a typedef for. However,
>> nothing noticed because the header.chk logic is also broken (fixed
>> subsequently).
>>
>> Strip the guard from the public header, and remove compensation from
>> devicemodel's private.h. Fix the dmop design doc to discuss both reasons
>> behind the the ABI design.
>>
>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
>> Release-Acked-by: Ian Jackson <i...@xenproject.org>
>> ---
>> CC: Jan Beulich <jbeul...@suse.com>
>> CC: Roger Pau Monné <roger....@citrix.com>
>> CC: Wei Liu <w...@xen.org>
>> CC: Paul Durrant <p...@xen.org>
>> CC: Ian Jackson <i...@xenproject.org>
>>
>> v2:
>> * Patch dmop.pandoc as well.
>>
>> For 4.15. This is a build fix, even if current staging can't spot the
>> breakage.
> Release-Acked-by: Ian Jackson <i...@xenproject.org>
>
> I am going to stop giving acks for this kind of thing fairly shorty.
Thanks, but you already release acked it. This is the requested update
including the documentation change.
~Andrew
