On 3/18/21 7:28 PM, Stefano Stabellini wrote: > > So, I'll follow you suggestion, keep the x86 side named as it is today, > and provide a tiny wrapper so that we can still have an arch-neutral > xen_swiotlb_detect function (on x86 just calls pci_xen_swiotlb_detect.)
But now on x86 side we end up with a routine that noone calls. And pci_xen_swiotlb_detect() becomes not __init and so it will have to stick around after boot for no good reason. (You could have made it __ref btw). I think we should leave x86 alone. And if there is a declaration in include/xen/swiotlb-xen.h that's only relevant to ARM --- well, so be it. Or perhaps you can create arch/arm/include/asm/xen/swiotlb-xen.h -boris
