On 26/01/2021 09:53, Jan Beulich wrote:
All users have been removed in earlier changes.

This is not entirely correct given there is a still a user of...


Requested-by: Andrew Cooper <andrew.coop...@citrix.com>
Signed-off-by: Jan Beulich <jbeul...@suse.com>
---
v3: New.

--- a/xen/arch/arm/efi/efi-dom0.c
+++ b/xen/arch/arm/efi/efi-dom0.c
@@ -28,7 +28,7 @@
  #include <asm/setup.h>
  #include <asm/acpi.h>
  #include "../../../common/decompress.h"
-#define XZ_EXTERN STATIC
+#define XZ_EXTERN static

STATIC here. So maybe you want to say "all but one users"?

Also, for consistency, I think you want to either remove INITDATA here or remove INIT in the patch that drop the last user.

Cheers,

  #include "../../../common/xz/crc32.c"
/* Constant to indicate "Xen" in unicode u16 format */
--- a/xen/common/decompress.h
+++ b/xen/common/decompress.h
@@ -7,9 +7,6 @@
  #include <xen/types.h>
  #include <xen/xmalloc.h>
-#define STATIC static
-#define INIT __init
-
  #define malloc xmalloc_bytes
  #define free xfree
@@ -18,9 +15,6 @@ #else -#define STATIC static
-#define INIT
-
  #undef __init /* tools/libs/guest/xg_private.h has its own one */
  #define __init
  #define __initdata



--
Julien Grall

Reply via email to