Hi Stefano,
On 30/11/2020 22:05, Stefano Stabellini wrote:
On Sat, 28 Nov 2020, Julien Grall wrote:
If you take the ``if`` alone, yes they are alignment check. But if you take
the overall code, then it will just compute which mapping size can be used.
However, what I am disputing here is "rely" because there are no assumption
made on the alignment in the loop (we are able to cater any size). In fact,
the fact mfn and vfn should be aligned to the mapping size is a requirement
from the hardware and not the implementation.
OK, maybe the "rely" gives a bad impression. What about:
This loop relies on mfn, vfn, and nr_mfn, to be all superpage aligned
(mfn and vfn have to be architecturally), and it uses `mask' to check
for that.
>
Feel free to reword it differently if you have a better idea.
I have used your new wording proposal.
Cheers,
--
Julien Grall
