On Tue, Mar 02, 2021 at 08:46:12PM -0500, Nick Rosbrook wrote: > At a Xen Summit design session for the golang bindings (see [1]), we > agreed that it would be beneficial to expand the libxl IDL with function > support. In addition to benefiting libxl itself, this would allow other > language bindings to easily generate function wrappers. > > The first version of this RFC is quite old [1]. I did address comments > on the original RFC, but also expanded the scope a bit. As a way to > evaluate function support, I worked on using this addition to the IDL to > generate device add/remove/destroy functions, and removing the > corresponding macros in libxl_internal.h. However, I stopped short of > actually completing a build with this in place, as I thought it made > sense to get feedback on the idea before working on the next step.
The series looks good to me, beside a few detail. Cheers, -- Anthony PERARD
