Re: [PATCH v4 09/10] libs/{light,guest}: implement xc_cpuid_apply_policy in libxl

[Roger Pau Monné]

On Fri, May 07, 2021 at 01:04:21PM +0200, Roger Pau Monne wrote:
> diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
> index eb6feaa96d1..6d17e89191f 100644
> --- a/tools/libs/light/libxl_cpuid.c
> +++ b/tools/libs/light/libxl_cpuid.c
> @@ -430,9 +430,11 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, 
> bool restore,
>                          libxl_domain_build_info *info)
>  {
>      GC_INIT(ctx);
> +    xc_cpu_policy_t *policy = NULL;
> +    bool hvm = info->type == LIBXL_DOMAIN_TYPE_HVM;

This is wrong and should instead be:

bool hvm = info->type != LIBXL_DOMAIN_TYPE_PV;

To account for libxl having a different domain type for PVH. I've
fixed it on my local copy of the patch.

Maybe the variable should also have a different name? I really cannot
think of any other name short of 'translated' or hvm_container. Let me
know if I should change the variable name.

Roger.