> On 18 Jun 2021, at 14:17, Andrew Cooper <andrew.coop...@citrix.com> wrote: > > On 18/06/2021 11:45, Edwin Török wrote: >> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c >> b/tools/ocaml/libs/xc/xenctrl_stubs.c >> index d05d7bb30e..4a230de8b7 100644 >> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c >> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c >> @@ -34,6 +34,9 @@ >> #include <xenctrl.h> >> #include <xen-tools/libs.h> >> >> +#include <xen/lib/x86/cpuid.h> >> +#include <xen/lib/x86/msr.h> > > https://gitlab.com/xen-project/patchew/xen/-/jobs/1358403495 > > CI says no. This needs to be behind a suitable ifdef, for non-x86 builds.
Should the stubs be disabled completely and raise ENOSYS/failwith on non-x86 (e.g. ARM), or are there plans on doing equivalent CPU policy on ARM at some point? —Edwin > > (I've not looked at the rest of the patch yet. I'll get around to it at > some point.) > > ~Andrew
