On Fri, 2006-09-22 at 19:32 +0900, SUZUKI Kazuhiro wrote:
> [1/12] patch for MCA handler.[mca-mca.patch]
Looks good, a couple minor comments:
* It looks like we're not returning a value for several functions
that specify a return type. Please make sure the code compiles
cleanly.
* #define'ing mod_timer to set_timer may help remove #ifdef XEN in
a few places.
* You might make a comment about the origin of
disable_irq_nosync() and enable_irq() since they appear to be
unchanged copies of the generic IRQ functions from Linux.
Thanks,
Alex
--
Alex Williamson HP Open Source & Linux Org.
_______________________________________________
Xen-ia64-devel mailing list
[email protected]
http://lists.xensource.com/xen-ia64-devel
