Isaku Yamahata wrote: > On Sat, Sep 27, 2008 at 01:40:49PM +0800, Xu, Anthony wrote: >> Add pci configuration code, which is needed by VTD >> >> Signed-off-by; Anthony Xu < [EMAIL PROTECTED] > >> >> >> The new one, I put pci.c under arch/ia64/xen, since it only uses two >> functions of linux pci.c, I don't want to pull the whole pci.c in >> xen. > > I see. I understood why you ended in the patch. > Hmm, looking at xen-unstable.hg/xen/arch/x86/pci.c, > Only pci_conf_read()/pci_conf_write() are different, other functions > seems same to x86's. > So please split out same functions into arch common file, > probably xen/drivers/pci/pci.c or something acceptable for Keir. > Then add pci_conf_read()/pci_conf_write() in xen/arch/ia64/xen/pci.c.
Good suggestion! I'll make the patches. BTW, how about the other two patches I sent out? Thanks, Anthony _______________________________________________ Xen-ia64-devel mailing list Xenemail@example.com http://lists.xensource.com/xen-ia64-devel