Hi Ian, >>>>> On Thu, 16 Sep 2010 18:08:12 +0100 >>>>> ian.jack...@eu.citrix.com(Ian Jackson) said: > > KUWAMURA Shin'ya writes ("[Xen-devel] Re: [PATCH] [Linux] ia64, xencomm: fix > 1028:6f7bda25a4de"): > > I fixed this warning by adding an #include line. I attached the patch. > ... > > +#include <xen/interface/xen-compat.h> > > +#define __XEN_TOOLS__ > > Why do you choose to #define __XEN_TOOLS__ rather than __XEN__ (which > latter is already defined in this file, as Jan notes) ? > Does moving the definition of __XEN__ further up cause other problems ?
__XEN__ causes the following compilation error: In file included from include2/asm/page.h:236, from include2/asm/ptrace.h:234, from include2/asm/processor.h:19, from include2/asm/thread_info.h:11, from /linux-2.6.18-xen.hg/include/linux/thread_info.h:21, from /linux-2.6.18-xen.hg/include/linux/preempt.h:9, from /linux-2.6.18-xen.hg/include/linux/spinlock.h:49, from /linux-2.6.18-xen.hg/include/linux/mmzone.h:7, from /linux-2.6.18-xen.hg/include/linux/gfp.h:4, from /linux-2.6.18-xen.hg/arch/ia64/xen/xcom_privcmd.c:23: include2/asm/hypervisor.h:63: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token The line of the problem is as follows: extern shared_info_t *HYPERVISOR_shared_info; The identifier `shared_info_t' is defined in include/xen/interface/xen.h if __XEN__ is NOT defined: include/xen/interface/xen.h: #ifndef __XEN__ typedef struct shared_info shared_info_t; #endif Best regards, -- KUWAMURA Shin'ya _______________________________________________ Xen-ia64-devel mailing list Xenemail@example.com http://lists.xensource.com/xen-ia64-devel