On Aug 14, 2006, at 6:50 PM, Hollis Blanchard wrote:

On Mon, 2006-08-14 at 17:48 -0400, Jimi Xenidis wrote:
On Aug 14, 2006, at 4:57 PM, Hollis Blanchard wrote:

Why do we free the HTAB in arch_domain_destroy(),
Xen heap
but free the RMA in
domain_relinquish_resources()?
Domheap

everytime you release !xenheap memory, it checks t->tot_pages and if
its zero releases a d->recnt. only when the refcnt = 1 (made zero by
destroy) will destroy get called.

OK, to expand on your answer a bit, the difference is that the HTAB is
allocated from the Xen heap, while the RMA is allocated from the domain
heap. We have to free all domain heap memory in
domain_relinquish_resources(), and only then will domain_destroy() be
called.

I think it might make sense to allocate the HTAB from the domain heap
instead, but it's working for now...

maybe, can't see why not. In fact I'd like to see the domain give up their own non-RMA memory to "make" an htab. This allows for a very clean max_domains = (memory - 64M)/memory_per_domain. Makes configuration-management way easier.

/me sees hollis with that look on his face again :)
-JX



_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel

Reply via email to