# HG changeset patch
# User Jimi Xenidis <[EMAIL PROTECTED]>
# Node ID 1c351e87e031ada2802fc909b42658132f836e77
# Parent  d9cda0370e6e268ecacccbbd1c2725ee1c2ddb2c
[POWERPC][XEN] Fix race in timebase sync logic

The SMP timebase sync code that recently went in has a race in which
secondary processor X+1 can potentially take the timebase offset that is
still in flight for secondary processor X.  The cause of this was
marking a secondary processor online from the boot cpu and then trying
to wait for the secondary processor to mark itself online.

Signed-off-by: Amos Waterland <[EMAIL PROTECTED]>
---
 xen/arch/powerpc/setup.c |    1 -
 1 files changed, 1 deletion(-)

diff -r d9cda0370e6e -r 1c351e87e031 xen/arch/powerpc/setup.c
--- a/xen/arch/powerpc/setup.c  Fri Sep 08 10:23:56 2006 -0500
+++ b/xen/arch/powerpc/setup.c  Fri Sep 08 13:17:03 2006 -0400
@@ -244,7 +244,6 @@ static int kick_secondary_cpus(int maxcp
         if (cpuid >= maxcpus)
             break;
         init_parea(cpuid);
-        cpu_set(cpuid, cpu_online_map);
         smp_generic_give_timebase();
 
         /* wait for it */

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel

Reply via email to