[EMAIL PROTECTED] wrote on 09/13/2006 10:51:29 AM:

> > +
> > +static inline
> > +int acm_x86_init(multiboot_info_t *mbi,
> > +                 unsigned int *initrdidx,
> > +                 unsigned long initial_images_start)
> > +{
> > +    return 0;
> > +}
> > +
> > +#endif
> > +
> > +#endif
>
> These are way too big to be static inlines. Make them regular functions
> please.
>
> Other than that, this patch seems great.


Don't want to have that checked in so far, though.

What about the multiboot code. Do you think PPC will be able to also use this part? Not that I would move it, it's more out of curiosity.

   Stefan
_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel

Reply via email to