Hi Mark, just some quick comments...
On Thu, 2006-10-05 at 04:09 -0400, Mark F Mergen wrote:
>
> -void do_dec(struct cpu_user_regs *regs)
> +void do_dec(struct cpu_user_regs *regs, struct vcpu* vcpu)
...
> -void program_exception(struct cpu_user_regs *regs, unsigned long
> cookie)
> +void program_exception(struct cpu_user_regs *regs,
> + unsigned long cookie, struct vcpu* vcpu)
...
> -void deliver_ee(struct cpu_user_regs *regs)
> +void deliver_ee(struct cpu_user_regs *regs, struct vcpu* vcpu)
I think you should simply use 'current' inside these exception handlers.
> - if (regs->msr & MSR_PR) {
> + if ((regs->msr & MSR_PR) && (current->arch.vmsr & MSR_PR)) {
Could you define a "in_usermode(regs)" accessor and use that instead?
> @@ -362,6 +366,9 @@ static void __init __start_xen(multiboot
> dom0->vcpu[0]->cpu_affinity = cpumask_of_cpu(0);
>
> set_bit(_DOMF_privileged, &dom0->domain_flags);
> + if (opt_nohv)
> + set_bit(_DOMF_prob, &dom0->domain_flags);
> +
> /* post-create hooks sets security label */
> acm_post_domain0_create(dom0->domain_id);
Does this mean you only have dom0 working, or domU as well?
I'm not going to go through the exception handler changes right now...
--
Hollis Blanchard
IBM Linux Technology Center
_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel
