On 28/8/07 07:17, "Isaku Yamahata" <[EMAIL PROTECTED]> wrote:
> +static int > +xencomm_ctxt_next(struct xencomm_ctxt *ctxt, int i) > +{ > + BUG_ON(i >= ctxt->nr_addrs); > + /* in i == 0 case, we already calculated in xecomm_addr_init() */ > + if ( i != 0 ) > + ctxt->address++; This function may deserve a comment -- what is it for? The 'i == 0' comment is confusing, and appears to refer to a function that doesn't exist (I couldn't find any function with suffix _addr_init()). These patches are all in the staging tree now, so provide delta patches to apply on top. -- Keir _______________________________________________ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel