Jan Kiszka wrote:
Hi all,
that's what reusing drivers also gives us: Paolo found a small but ugly
bug in the 16550A driver, see attached fix and Changelog (for both 2.0.x
and 2.1.x).
Applied, thanks.
Jan
------------------------------------------------------------------------
Index: ChangeLog
===================================================================
--- ChangeLog (revision 182)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2005-11-25 Jan Kiszka <[EMAIL PROTECTED]>
+
+ * drivers/16550A/16550A.c (RTSER_RTIOC_SET_CONFIG): Fix ENOMEM detection
+ (once again). Found by Paolo Mantegazza through cross-usage.
+
2005-11-21 Philippe Gerum <[EMAIL PROTECTED]>
* skins/native, nucleus/pipe.c: Globally replace ENOSPC by
Index: drivers/16550A/16550A.c
===================================================================
--- drivers/16550A/16550A.c (revision 182)
+++ drivers/16550A/16550A.c (working copy)
@@ -587,10 +587,9 @@
else
hist_buf =
rtdm_malloc(IN_BUFFER_SIZE * sizeof(uint64_t));
+ if (!hist_buf)
+ return -ENOMEM;
}
-
- if (!hist_buf)
- return -ENOMEM;
}
rt_16550_set_config(ctx, config, &hist_buf);
@@ -1025,7 +1024,7 @@
device_class: RTDM_CLASS_SERIAL,
device_sub_class: RTDM_SUBCLASS_16550A,
driver_name: "rt_16550A",
- driver_version: RTDM_DRIVER_VER(1, 2, 0),
+ driver_version: RTDM_DRIVER_VER(1, 2, 1),
peripheral_name: "UART 16550A",
provider_name: "Jan Kiszka",
};
------------------------------------------------------------------------
Index: ksrc/drivers/16550A/16550A.c
===================================================================
--- ksrc/drivers/16550A/16550A.c (revision 182)
+++ ksrc/drivers/16550A/16550A.c (working copy)
@@ -589,10 +589,9 @@
else
hist_buf =
rtdm_malloc(IN_BUFFER_SIZE * sizeof(uint64_t));
+ if (!hist_buf)
+ return -ENOMEM;
}
-
- if (!hist_buf)
- return -ENOMEM;
}
rt_16550_set_config(ctx, config, &hist_buf);
@@ -1027,7 +1026,7 @@
device_class: RTDM_CLASS_SERIAL,
device_sub_class: RTDM_SUBCLASS_16550A,
driver_name: "rt_16550A",
- driver_version: RTDM_DRIVER_VER(1, 2, 0),
+ driver_version: RTDM_DRIVER_VER(1, 2, 1),
peripheral_name: "UART 16550A",
provider_name: "Jan Kiszka",
};
------------------------------------------------------------------------
_______________________________________________
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core
--
Philippe.
_______________________________________________
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core
