Heikki Lindholm wrote:
Anders Blomdell kirjoitti:

In the following code (ppc), shouldn't first be either declared static or deleted? To me it looks like first is always equal to one when the else clause is evaluated.


You're right. "first" doesn't need to be there at all, it's probably an old copy of something in the kernel.


Yep; used to be a while() loop in the original implementation we do not perform 
here.

asmlinkage int __ipipe_grab_irq(struct pt_regs *regs)
{
        extern int ppc_spurious_interrupts;
        ipipe_declare_cpuid;
        int irq, first = 1;

        if ((irq = ppc_md.get_irq(regs)) >= 0) {
                __ipipe_handle_irq(irq, regs);
                first = 0;
        } else if (irq != -2 && first)
                ppc_spurious_interrupts++;

        ipipe_load_cpuid();

        return (ipipe_percpu_domain[cpuid] == ipipe_root_domain &&
                !test_bit(IPIPE_STALL_FLAG,
                          &ipipe_root_domain->cpudata[cpuid].status));
}


Regards

Anders Blomdell



_______________________________________________
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core



_______________________________________________
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core



--

Philippe.

_______________________________________________
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core

Reply via email to