Jan Kiszka wrote: > Jan Kiszka wrote: >> Gilles Chanteperdrix wrote: >>> Jan Kiszka wrote: >>>> Gilles Chanteperdrix wrote: >>>>> Ok for returning -EINTR, it is documented. Kernel-space is not so >>>>> different from user-space, rt_task_unblock could wake-up a kernel-space >>>>> task blocked in a call to rt_cond_wait. >>>>> >>>>> However, if the epilogue returns an error, we must return it. >>>>> >>>> OK for this. Pushed an update, but I also modified it further to avoid >>>> returning without the mutex lock unless that one is also failing. Maybe >>>> in-kernel POSIX requires the same fix, will check. >>> Still not OK. You should reacquire the mutex only if the error is 0, >>> -ETIMEDOUT or -EINTR. With any other error, we do not know if we can >>> call the epilogue safely. >> We _must_ reacquire the mutex - but, granted, we actually have to take >> care of invalid cond objects. Lot's of bugs... >> > > Was only an issue of my POSIX patch, native was not touching cond in the > epilogue. Update pushed.
Ok. I have work to do, so, will stop commenting each of your patches. But no, I will not take this one. -- Gilles. _______________________________________________ Xenomai-core mailing list Xenomaiemail@example.com https://mail.gna.org/listinfo/xenomai-core