On 18.08.2010 11:06, Gilles Chanteperdrix wrote:
> Paul wrote:
>   
>> On Wednesday 18 August 2010, Gilles Chanteperdrix wrote:
>>     
>>> Stefan Kisdaroczi wrote:
>>>       
>>>> On 17.08.2010 15:51, Hemal C.Bavishi wrote:
>>>>         
>>>>> When I tried to compile it with the latest version of kernel with
>>>>> xenomai 2.5.4, I am getting following errors in Xenomai (disable
>>>>> CONFIG_SMP, enable CONFIG_X86_UP_APIC and CONFIG_X86_UP_IOAPIC
>>>>> (*).)
>>>>>           
>>>> Just tested, got the same build error with 2.6.34.
>>>> If I patch 2.6.34 with prepare-kernel [1] it compiles,
>>>> if I use the debian packaged patch generated with prepare-patch [2]
>>>> it fails.
>>>>
>>>> I guess a fix is needed in prepare-patch for 2.6.34, but no time to
>>>> look closer now.
>>>>
>>>> Stefan
>>>>
>>>> [1] xenomai-2.5.4/scripts/prepare-kernel.sh
>>>> [2] xenomai-2.5.4/debian/prepare-patch.sh
>>>>         
>>> prepare-kernel.sh has a "--outpatch" option, which seems to be able
>>> to generate patches, so, would not it be possible to modify
>>> prepare-patch to simply call prepare-kernel.sh with the --outpatch
>>> option?
>>>
>>> This way, we will not have to duplicate into prepare-patch.sh the
>>> modifications we make to prepare-kernel.sh.
>>>       
>> The debian/prepare-patch.sh does not require a kernel source tree and 
>> generates patches for multiple kernels & arches - It is a fudge, but it 
>> works for the most part and does not impose dependencies of multiple 
>> kernel source trees on package build systems.
>>     
> Ok. Understood. The thing is that prepare-patch.sh is broken, so now may
> be a good occasion to merge its functionality in prepare-kernel.sh, so
> that we do not duplicate the code in these two really non-trivial scripts.
>   

Hi Gilles,

There is another copy. The debian/ directory from the xenomai tree is
not used for debian packages at debian.org. The Debian Maintainer Roland
Stigge has his own debian/ directory.
I submitted a bugreport including the patch for this bug to debian [1].
If we move the prepare-patch.sh out of the debian/ dir (suggested by
Roland), that would not be necessary.

I suggest to move debian/prepare-patch.sh to
scripts/prepare-debian-patch.sh.
I'll create a patch if you agree.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593585

Stefan


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xenomai-help mailing list
[email protected]
https://mail.gna.org/listinfo/xenomai-help

Reply via email to