On 05/04/2011 08:36 AM, [email protected] wrote:
>> From: Gilles Chanteperdrix [mailto:[email protected]]
>> Sent: Tuesday, May 03, 2011 7:36 PM
>> ...
>>>> On 05/03/2011 10:15 AM, [email protected] wrote:
>>>>> ...
>>>>> We at manroland now use (with Xenomai 2.4) the attached patch, which
>>>>> implements the readv file operation in the rtpipe driver so that the
>>>>> assertion "One read() per rt_pipe_write()" (message boundaries
>>>>> preserved) covers readv(2) also.
>> ...
>> Unfortunately, the patch as is is a bit hard to read. IMO, only
>> implementing readv will result in a more straight-forward implementation
>> which we could merge.
>
> I understand. If you prefer, I can provide a patch which multiplies out the
> functions to a separate readv, though this will result in code duplication of
> the whole read function. Alternatively, I could comment the changes so that
> they are easier to read.
> Please let me know which flavour you favour.
What I suggest, is that you make a patch which removes the read
implementation and adds the readv implementation. In this case, the
kernel will use readv to implement read anyway, and there will be no
code duplication.
--
Gilles.
_______________________________________________
Xenomai-help mailing list
[email protected]
https://mail.gna.org/listinfo/xenomai-help
