On Wed, Oct 26, 2011 at 12:21 PM, Philippe Gerum <r...@xenomai.org> wrote: > On 10/19/2011 09:35 AM, Thomas De Schampheleire wrote: >> >> While psos interface accepts 4 character ids, non null terminated, >> xenomai uses longer ids which must be null terminated. Revert to >> the behaviour of psos interface, while allowing long id strings if >> the global variable psos_long_names is set to non-zero. >> >> This patch ports the original fix from xenomai to xenomai-forge, >> fixing following problems: >> * a bug in __psos_maybe_short_name so that only 3 characters are >> retained >> * the call to __psos_maybe_short_name also needs to be done in the >> ident functions >> * the pt_create and pt_ident functions also need to be adapted >> > > Please merge long_names.h into psos.h, having a separate header for this is > way overkill and brings nothing.
It avoids exposing an internal interface to applications through psos.h. If anything, I think we should make a psos_internal.h or whatever, that can host __psos_maybe_short_name among others. ~Thomas _______________________________________________ Xenomai-help mailing list Xenomai-help@gna.org https://mail.gna.org/listinfo/xenomai-help
