DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3813>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3813

BinHTTPURLInputStream has weak HTTP request capabilities

[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|Enhancement                 |Normal
            Version|1.5.1                       |Nightly build



------- Additional Comments From [EMAIL PROTECTED]  2001-09-25 11:18 -------
Thanks Kevin.

I wasn't able to get the full 14-09-2001 build working, but the copy of 
BinHTTPURLInputStream with that release got me started in the right direction. 
However, I have a concern...

A snippet of new code in the 14-09-2001 release of BinHTTPURLInputStream looks 
like the following:

    if (queryAsCharStar != 0)
    {           
        fBuffer[strlen(fBuffer)] = chQuestion;
        strcat(fBuffer, queryAsCharStar);
    }

Now, it's been a long time since I've done much with C++, but if I remember 
correctly, overwriting the terminating null character isn't usually a good 
idea. Why was the code written this way? On my build, the code just flat out 
doesn't work. None of the additional information (protocol, host, etc.) is 
written out to fBuffer after the terminating null is overwritten by the '?'. 

I rewrote my copy to look like the following and now everything is working fine:

    if (queryAsCharStar != 0)
    {           
        strcat(fBuffer, "?");
        strcat(fBuffer, queryAsCharStar);
    }

- Ken

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to