DO NOT REPLY [Bug 4177] New: - setupRange uses non-portable code

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4177>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4177

setupRange uses non-portable code

           Summary: setupRange uses non-portable code
           Product: Xerces-C++
           Version: 1.5.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Utilities
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


The function setupRange() in src/util/regx/XMLRangeFactory.cpp contains the 
following non-portable code on line 120:

    while (*pchCur) {
        rangeTok->addRange(*pchCur, *pchCur++);
    }

C++ does not guarantee whether the first or last argument to a function will be 
processed first. Better code would be:

    while (*pchCur) {
        const XMLCh ch = *pchCur++;
        rangeTok->addRange(ch, ch);
    }
or
    while (*pchCur) {
        rangeTok->addRange(*pchCur, *pchCur);
        ++pchCur;
    }

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]