Re: macro readability

[David N Bertoni/Cambridge/IBM]

There must be a space between the macro XERCES_CPP_NAMESPACE_QUALIFIER and
InputSource, so I don't see how you could ever have this:

   class XERCES_CPP_NAMESPACE_QUALIFIERInputSource;

Does your compiler actually accept this?  If so, you'd best get a new one.

Why don't you just use the following?

   class XERCES_CPP_NAMESPACE_QUALIFIER InputSource;

That seems very readable to me, but you can use more spaces if one isn't
enough.

Dave



                                                                                       
                                                  
                      "Peter A.                                                        
                                                  
                      Volchek"                 To:      "Xerces-Dev" 
<[EMAIL PROTECTED]>                                       
                      <[EMAIL PROTECTED]         cc:      (bcc: David N 
Bertoni/Cambridge/IBM)                                             
                      d.ua>                    Subject: macro readability              
                                                  
                                                                                       
                                                  
                      01/08/2003 06:46                                                 
                                                  
                      AM                                                               
                                                  
                      Please respond                                                   
                                                  
                      to xerces-c-dev                                                  
                                                  
                                                                                       
                                                  



To: team

In XercesDefs.hpp you have defined the macro
XERCES_CPP_NAMESPACE_QUALIFIER.

Suppose that somewhere in the code I want to forward declare any Xerces
class, like:

class InputSource;
void SomeFunc( InputSource& );

But this cause the compiler to complain about the umbiguous inputSource.
The correct definition is:

class XERCES_CPP_NAMESPACE_QUALIFIERInputSource;
void SomeFunc( XERCES_CPP_NAMESPACE_QUALIFIERInputSource& );

But if you change the MACRO to have an extra underscore at the end, the
code would be more readable. Compare:

class XERCES_CPP_NAMESPACE_QUALIFIER_InputSource;
void SomeFunc( XERCES_CPP_NAMESPACE_QUALIFIER_InputSource& );

Ideas ?

Regards,
Peter A. Volchek




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]