Re: XMLPlatformUtils::compareAndSwap fn

[David N Bertoni/Cambridge/IBM]

The whole point of the ifdef is that all Windows builds use the inline
assembly code.  The ifdef is checked at compile time, but the assumption is
you would want to build on NT or Win2000, but run on Windows 95.

Dave



                                                                                       
                                                          
                      <[EMAIL PROTECTED]                                               
                                                            
                      ngcast.com>              To:      <[EMAIL PROTECTED]>            
                                                
                                               cc:      (bcc: David N 
Bertoni/Cambridge/IBM)                                                     
                      03/14/2003 08:16         Subject: 
XMLPlatformUtils::compareAndSwap fn                                                    
  
                      AM                                                               
                                                          
                      Please respond                                                   
                                                          
                      to xerces-c-dev                                                  
                                                          
                                                                                       
                                                          



I was just following up on my previous reply and was puzzled by the
implementation of this fn.

...

here, the developer has used #if defined(_MSC_VER) to branch to his inline
assembly code. But _MSC_VER is ALWAYS defined on Most windows versions. So,
I guess we would always be hitting the assembly code (unless you are using
win64). Does someone think this if define condition needs modifying ? we
may probably want to use _WIN32_WINNT or atleast check if _MSC_VER > 1000
or something like that.

-Vinayak

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]