Hi Adam,
my preference is to always include public headers in <>. I think its a style thing (unless anyone has a reason). If no-one objects I will happily commit your patches.
Gareth
Adam Heinz wrote:
What's the common opinion on mixing user includes with system includes? For example, xercesc/dom/DOMAttr.hpp contains:
#include <xercesc/util/XercesDefs.hpp> #include "DOMNode.hpp"
I'm using fairly strict compiler settings in Codewarrior 8.3, MacOS 10.2; notably, that I do not allow user and system includes to be mixed and matched. Currently, I do not see any reason why
#include <xercesc/util/XercesDefs.hpp> #include <xercesc/dom/DOMNode.hpp>
would be less preferred than the above. If nobody objects, I'll put in a defect and start submitting patches.
Adam Heinz Senior Software Developer Exstream Software
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Gareth Reakes, Managing Director Parthenon Computing +44-1865-811184 http://www.parthcomp.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]