[ http://issues.apache.org/jira/browse/XERCESC-1327?page=comments#action_57894 ] Robert Buck commented on XERCESC-1327: --------------------------------------
I'm not offended, and I hope I am not offending anyone myself. But I do, and did, want to make it abundantly clear that for some software a silent incorrect result can cause death. And I do feel that perhaps people were not feeling the gravity of the situation, at least for developers of critical software. I really wish that as standard practice for Xerces-C, that builds would always occur with warning levels set to their highest, and as a matter of practice, any time someone commits a file - they are responsible for ensuring the file is warning free. In this way, a bulk of the code would be cleaned up in little time at all. I have brought up the issue of warnings once before, and specifically I suggested that Xerces-C should be built warnings free, with warnings cranked all the way up. And as I recall someone said, "that's useless because it's safe to ignore most warnings anyway". Recent situations show how valuable warnings can be at identifying potential bugs, and can spur questions where people ask, "is this really the best way of doing such and such". Sometimes refactoring, or redesign, results. And that's great. I hope we can come to some agreement on the present issue. > Change all enum values from ALLCAPS to MixedCase > ------------------------------------------------ > > Key: XERCESC-1327 > URL: http://issues.apache.org/jira/browse/XERCESC-1327 > Project: Xerces-C++ > Type: Bug > Components: Build > Versions: 2.6.0 > Environment: All > Reporter: Robert Buck > > The enum values in Xerces-C are in ALLCAPS, which violates general > programming practice, which reserves ALLCAPS identifiers for C preprocessor > macros. This is a huge problem for people integrating diverse 3rd-party > libraries and Xerces-C, as the enum values often collide with macro > expressions. The result is thousands of lines of nearly indecipherable errors > being emitted from compilers. > Please change all enum values to "MixedCase". If you happen to be aware of > any other ALLCAPS identifiers in Xerces-C, change those too. > This is very critical. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
