"George T. Joseph" wrote: > ChunkyByteArray didn't have a close() method so if > ChunkyByteArray.close() were called (and it IS being > called properly), it would be InputStream.close() that > was actually invoked. That's an empty method and > therefore a leak.
You are absolutely correct. This needs to be fixed. > So, I'll remove the calls to close() in ChunkyByteArray, > but the close() method itself needs to stay. Also, the > existing "fInputStream = null" statements have > to stay removed so close() can call fInputStream.close(). Exactly. In fact, the fInputStream field should never be set to null. But we need to make sure that there is no code that relies on the fact that the field is null in order to operate correctly. We may be fine just removing the assignments to null, though. -- Andy Clark * IBM, JTC - Silicon Valley * [EMAIL PROTECTED]
