[Bug 2433] - Crimson supports string-interning, but claims not to

[bugzilla]

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=2433

*** shadow/2433 Tue Jul  3 04:46:25 2001
--- shadow/2433.tmp.5688        Tue Jul  3 04:48:33 2001
***************
*** 19,22 ****
  through its SAX driver, for the convenience of client software.
  
  (Reported on Xerces-J, since there is no separate project for Crimson.
! (Ought to be, though.))
--- 19,71 ----
  through its SAX driver, for the convenience of client software.
  
  (Reported on Xerces-J, since there is no separate project for Crimson.
! (Ought to be, though.))
! 
! ------- Additional Comments From [EMAIL PROTECTED]  2001-07-03 04:48 -------
! The bug tracker wouldn't let me add the patch as an attachment (something about 
wrong ID), so I'm doing it here:
! 
! *** XMLReaderImpl.java.old    Tue Jul  3 13:20:50 2001
! --- XMLReaderImpl.java        Tue Jul  3 13:28:02 2001
! ***************
! *** 87,92 ****
! --- 87,94 ----
!               FEATURES + "external-general-entities";
!       private final static String EXTERNAL_PARAMETER =
!               FEATURES + "external-parameter-entities";
! +     private final static String STRING_INTERNING =
! +             FEATURES + "string-interning";
!   
!       // Features for org.sax.xml.ext.LexicalHandler
!       private final static String LEXICAL_PARAMETER_ENTITIES = FEATURES +
! ***************
! *** 155,161 ****
!           } else if (name.equals(VALIDATION)) {
!               return validation;
!           } else if (name.equals(EXTERNAL_GENERAL) ||
! !                    name.equals(EXTERNAL_PARAMETER)) {
!               return true;
!           } else if (name.equals(LEXICAL_PARAMETER_ENTITIES)) {
!               return false;
! --- 157,164 ----
!           } else if (name.equals(VALIDATION)) {
!               return validation;
!           } else if (name.equals(EXTERNAL_GENERAL) ||
! !                    name.equals(EXTERNAL_PARAMETER) ||
! !                name.equals(STRING_INTERNING)) {
!               return true;
!           } else if (name.equals(LEXICAL_PARAMETER_ENTITIES)) {
!               return false;
! ***************
! *** 190,195 ****
! --- 193,203 ----
!               if (!prefixes && !namespaces) {
!                   namespaces = true;
!               }
! +         } else if (name.equals(STRING_INTERNING)) {
! +             checkNotParsing("feature", name);
! +         if (!state)
! +           throw new SAXNotSupportedException("Feature " + name +
! +                                              " cannot be turned off");
!           } else if (name.equals(VALIDATION)) {
!               checkNotParsing("feature", name);
!               if (validation != state) {

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]