Hi Pavani,

First about your patch--diff -u is the best command to use when submitting
patches; at least that's what we've become used to on this list.  It's also
often best not to end the attachment file name with a .txt extension, since
some e-mail clients (cf. Lotus Notes...) like to in-line those attachments.

Now about the "bug":  I think that GB2312 is the IANA name for this
encoding, not gb2312.  So I don't think there's a bug in this case at all;
GB2312 works like a charm.  If no one disagrees I'll tag the bug as
invalid.

Cheers,
Neil
Neil Graham
XML Parser Development
IBM Toronto Lab
Phone:  416-448-3519, T/L 778-3519
E-mail:  [EMAIL PROTECTED]



Pavani Mukthipudi <[EMAIL PROTECTED]> on 09/06/2001 09:49:47 AM

Please respond to [EMAIL PROTECTED]

To:   [EMAIL PROTECTED]
cc:
Subject:  patch for bug# 3449 [xerces2] auto change the existing encoding
      to wrong encoding




Please find the attached patch for bug# 3449.

Pavani


--

Pavani Mukthipudi
Sun Microsystems Inc.

Phone: 080 - 2298989   Extn: 87390
? build
? patch4.txt
Index: src/org/apache/xerces/impl/XMLEntityManager.java
===================================================================
RCS file:
/home/cvspublic/xml-xerces/java/src/org/apache/xerces/impl/XMLEntityManager.java,v

retrieving revision 1.3
diff -c -r1.3 XMLEntityManager.java
*** src/org/apache/xerces/impl/XMLEntityManager.java          2001/08/23
08:09:02        1.3
--- src/org/apache/xerces/impl/XMLEntityManager.java          2001/09/06
13:28:13
***************
*** 1213,1219 ****
          }

          // try to use a Java reader
!         String javaEncoding = EncodingMap.getIANA2JavaMapping(encoding);
          if (javaEncoding == null) {
              javaEncoding = encoding;
          }
--- 1213,1219 ----
          }

          // try to use a Java reader
!         String javaEncoding = EncodingMap.getIANA2JavaMapping(ENCODING);
          if (javaEncoding == null) {
              javaEncoding = encoding;
          }

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to