Elena Litani wrote: > I would like to propose to modify startExternalSubset() method in > XMLDTDHandler to include XMLResourceIdentifier: > public void startExternalSubset(XMLResourceIdentifier identifier, > Augmentations augmentations)
I read your arguments, looked at the spec, inspected the code, and completely agree with you. (How often does *that* happen? Probably less than Haley's Comet... ;) I fully support the recommended change. I would just warn you that a "build clean" may not properly find the files that implement this interface. There are some cases where the location of the missing method (I say "missing" because the prototype has changed) is not apparent. For example, any class that that implements the interface but is abstract may cause subclasses to fail but the real cause of the problem is the base class. For example, the abstract parsers frequently caused this problem when I was updating the codebase to conform to changes we decided when developing XNI. In short, fix the method in the correct place -- don't just add the method in a class because the compiler complained. It may even be best to just do a global search for the string "startExternalSubset" to make the mods. (Also fix the Javadoc while you're at it.) Thanks! -- Andy Clark * [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
