DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8840>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8840 SAX out of memory if external-SchemaLocation not used in instance ------- Additional Comments From [EMAIL PROTECTED] 2002-05-15 16:30 ------- I took a look at the current source, as opposed to the source for the 2.0.1 release. It looks to me like the bug I reported should already be fixed by the change: version 1.47, 2002/03/05 23:02:14, made by sandygao That change goes more to the heart of the matter I was reporting, and removes the offending return statement in the middle of the method. The version 1.61 change that you just made, does however address some of my concerns: 1) I was concerned that fBuffer.setLength(0) should also be accompanied by: fSawCharacters = false; fSawChildren = false; You seem to have come to the same conclusion, and you've made sure that all three statements are executed. 2) I was concerned about branching out of the middle of the method, because it was not clear what cleanup code had to be executed. You've addressed that partially by moving the cleanup code earlier, so it is now executed by all paths through the method. 3) I'm stilly wary of returns in the middle of a large method. They lead to exactly the type of problem I was reporting. There's still two of those left. But no two people have the same sense of aesthetics on this kind of thing. I'm not quite sure how to test with the fix. Do you know if the 1.61 version of the source is compatible with the rest of the source from 2.0.1? Do you know if there are any plans for a Xerces 2.0.2 anytime soon? --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
