+1 to all of this. Ted
On Fri, 2002-08-16 at 06:35, [EMAIL PROTECTED] wrote: > Hi folks, > > Here's my +1 to adding set/getDocumentSource to XMLDocumentHandler. > > But, I'm with Andy on keeping the behaviour explicit: I think it would be > far too easy for an XMLDocumentHandler implementor to forget the implied > call to setDocumentSource in setDocumentHandler, and this would cause bad > things to happen in configurations that relied on the behaviour. If we're > going to make a change in an XNI interface of this importance, moving the > ramifications to a few more classes can't hurt us. > > Cheers, > Neil > Neil Graham > XML Parser Development > IBM Toronto Lab > Phone: 905-413-3519, T/L 969-3519 > E-mail: [EMAIL PROTECTED] > > > > > |---------+----------------------------> > | | Arnaud Le | > | | Hors/Cupertino/IB| > | | M@IBMUS | > | | | > | | 08/15/2002 06:05 | > | | PM | > | | Please respond to| > | | xerces-j-dev | > | | | > |---------+----------------------------> > >>---------------------------------------------------------------------------------------------------------------------------------------------| > | > | > | To: [EMAIL PROTECTED] > | > | cc: > | > | Subject: Re: Performance and XNI change > | > | > | > | > | > >>---------------------------------------------------------------------------------------------------------------------------------------------| > > > > Elena Litani wrote: > > > > > So to set the pipeline we need to call (for filter components): > > f1.setDocumentHandler(f2); > > f2.setDocumentSource(f1); > > > > If a filter component wants to remove itself, it calls: > > this.documentSource.setDocumentHandler(this.documentHandler); > > this.documentHandler.setDocumentSource(this.documentSource); > > > > Correct? > > > > Yes. One additional possibility is to specify that setDocumentHandler > calls setDocumentSource. This way the application only has to do: > > f1.setDocumentHandler(f2); > > which does: f2.setSourceDocument(this); > > It's convenient for the caller. It guarantees that the two links don't > get out of sync. It requires fewer changes to the existing code which > will happen to do the right thing as soon as you change > setDocumentHandler implementation. > All it needs is proper javadoc so that people understand they don't need > to call setDocumenSource. But even if they did, it wouldn't hurt anyway. > > -- > Arnaud Le Hors - IBM, XML Standards Strategy Group / W3C AC Rep. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
