Hi Neeraj,
No, I have not tagged the code yet so I will commit the code with a minor
modification:
fXIncludeHandler.setDTDHandler(fDTDHandler) should be set before null
check, otherwise we might be holding an old reference to a DTDHandler from
XInclude component (even if user decideds to set DTDHandler to null before
the next parse).
Our XInclude tests did not catch this error (tests/xinclude) -- it would be
nice if we can have a test or two for testing this case, so it won't be
broken in the future. If you have such a test, please commit it to the CVS
after the release.
Unless, I hear about any other problem within next hour and a half, I will
start tagging and building Xerces.
Thank you for finding this problem and for submitting a patch!!
--
Elena Litani/ IBM Toronto
Wednesday, November 19, 2003 11:56 AM
To: [EMAIL PROTECTED]
cc:
From: Neeraj Bajaj <[EMAIL PROTECTED]>
Subject: Re: Important [Bug in XIncludeParserConfiguration]Re: CODE FREEZE
Hi Elena,
Since you have annonded the CODE FREEZE. I am not committing the fix
but have attatched with this mail :-)
Problem is pretty serious because DTD pipeline is not set properly.
Therefore any DOM based parser parsing XML document containin DOCTYPE
delcarations wont be able to get the information present (like
Notation/Entities etc)because of this. Same problem is there for SAX
parser. The problem exists for both XML 1.0 and XML 1.1 documents.
If you haven't tagged it yet we should make it part of Xerces2.6 release.
Thanks,
Neeraj
Neeraj Bajaj wrote:
> Hi Elena,
>
>
> I am not sure if we have time for any fix but I just found that
> there is very serious bug in Xerces when using XIncludeConfiguration.
> There are many DOM failures as a result of that. Infact things wont work
> if there is any DOCTYPE declaration inside the document. I would be
> sending the fix in few minutes.
>
>
> Thanks
> Neeraj
>
> Elena Litani wrote:
>
>>
>>
>>
>> Code freeze starts NOW till further notice.
>>
>> Committers can only commit minor doc changes (e.g. last minute fixes
for
>> releases.xml).
>>
>> If anyone finds a serious bug, please post a message to the mailing list
>> and we will postpone the release.
>>
>> Otherwise, we plan to go ahead and build and release Xerces tomorrow.
>>
>> Thank you,
>> --
>> Elena Litani/ IBM Toronto
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>
>
--
-- Neeraj
Index: XIncludeParserConfiguration.java
===================================================================
RCS file:
/home/cvs/xml-xerces/java/src/org/apache/xerces/parsers/XIncludeParserConfiguration.java,v
retrieving revision 1.5
diff -u -r1.5 XIncludeParserConfiguration.java
--- XIncludeParserConfiguration.java 14 Nov 2003 23:24:36 -0000 1.5
+++ XIncludeParserConfiguration.java 19 Nov 2003 16:46:55 -0000
@@ -165,6 +165,7 @@
fDTDProcessor.setDTDHandler(fXIncludeHandler);
fXIncludeHandler.setDTDSource(fDTDProcessor);
if (fDTDHandler != null) {
+ fXIncludeHandler.setDTDHandler(fDTDHandler);
fDTDHandler.setDTDSource(fXIncludeHandler);
}
@@ -201,6 +202,7 @@
fXML11DTDProcessor.setDTDHandler(fXIncludeHandler);
fXIncludeHandler.setDTDSource(fXML11DTDProcessor);
if (fDTDHandler != null) {
+ fXIncludeHandler.setDTDHandler(fDTDHandler);
fDTDHandler.setDTDSource(fXIncludeHandler);
}
@@ -236,4 +238,4 @@
super.setProperty(propertyId, value);
} // setProperty(String,Object)
-}
\ No newline at end of file
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
