https://bugzilla.xfce.org/show_bug.cgi?id=5730
Lionel Le Folgoc <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3587|0 |1 is obsolete| | --- Comment #11 from Lionel Le Folgoc <[email protected]> 2011-03-31 12:46:59 CEST --- Created attachment 3590 --> https://bugzilla.xfce.org/attachment.cgi?id=3590 Proposed patch (2) Thanks for the feedback! (In reply to comment #7) > The current patch looks ok. > > I have two suggestions though: > > 1) I think the button should only be sensitive when there is something to > delete. A check when creating the dialog is enough, no need to monitor. When > finishing the cache cleaning, we would just set the state to insensitive. It's > not a big deal but it makes sense IMO. > > 2) The description in the confirmation dialog could be improved by saying what > could potentially be lost. I don't know everything we can store in session > files, but at least saved applications. > > Re deleting Thunar and Xfwm4 session files, it makes sense IMO. 1) I think it's more annoying than expected, because the "save session" button can write items in there, and restarting Thunar/xfwm4 also (and in this case, if the button stays greyed out it's misleading). 2) I tried to improve that a bit, feel free to change it. (In reply to comment #9) > When you start a new session the thunar xfwm4 and other session files are > invalid because the app is assigned a new client-id, so you can safely delete > those too. I included a check to delete them as well. However, when thunar/xfwm4 starts, a state file is written for them with their *current* client-id... Is it really safe to remove that? (In reply to comment #10) > Officially xfce4-session does not depend on gio and because session files are > always local, I'd say a g_dir_open; walk; g_unlink; will do. Done. It doesn't delete everything though (I'm thinking about people using several desktop environments who won't be happy if everything is deleted, so I only delete "xfce4-session-*", "Thunar-*", "xfwm4-*"...). -- Configure bugmail: https://bugzilla.xfce.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Xfce-bugs mailing list [email protected] http://foo-projects.org/mailman/listinfo/xfce-bugs
