liquider <[email protected]> has asked for review: Bug 3887: add a way to run a command when clicking on systemload plugin https://bugzilla.xfce.org/show_bug.cgi?id=3887
Attachment 5336: run configurable command on click or context menu activation https://bugzilla.xfce.org/attachment.cgi?id=5336&action=edit ------- Additional Comments from liquider <[email protected]> Attached is a patch that does this. It is a configurable option, "System monitor", that defaults to "xfce4-taskmanager". It can be conditionally enabled (with a checkbox; disabled by default). When enabled, clicking anywhere on the plugin surface spawns the command and there is also a context menu item available. When disabled, clicking does nothing and there is no menu item. The patch introduces two new translatable labels: "System monitor:" in the configuration dialog, and "Run _System Monitor" in the context menu. The widgets in the configuration dialog aren't all perfectly aligned, but that problem precedes my contribution. :D I don't write much C (or any), so you're invited to give it a thorough review. Given the existing code-base, I think I did just fine. It seems to work well. :-) The patch was built against Debian's testing 1.1.1 archive as I didn't manage to compile the HEAD of your git repo (some autotools crazy I know nothing about). _______________________________________________ Xfce-bugs mailing list [email protected] https://mail.xfce.org/mailman/listinfo/xfce-bugs
