https://bugzilla.xfce.org/show_bug.cgi?id=14714
alexxcons <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] --- Comment #1 from alexxcons <[email protected]> --- Created attachment 8011 --> https://bugzilla.xfce.org/attachment.cgi?id=8011&action=edit patch The problem is, that thunar-tree-model is implemented as singleton. When a new thunar-tree-view is created, the tree-view registers itself in the single thunar-tree-model. The tree-view will be used by tree-model to decide if specific hidden files should be displayed. Since each thunar-window creates a fresh tree-view, the reference in tree-model will be overwritten by the tree-view of the new window. If the new window is closed, the reference will point to nowhere. An update of the tree on the old window may now result in a crash. According to gtk-doc, the tree-model seems to be the place where tree-items can be added / removed. And it does not make sense to register multiple tree-views in one tree-model (IMO each tree-view should have its own show/hide toggle) This fix just removes the singleton nature from the tree-model, so that each tree-view has its own tree-model. I checked all tree-model methods to see if this could have negative side-effects, and I as well did some testing. For me everything works fine. However I would be happy if someone else as well could test the patch before I push it. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Xfce-bugs mailing list [email protected] https://mail.xfce.org/mailman/listinfo/xfce-bugs
