https://bugzilla.xfce.org/show_bug.cgi?id=15367

--- Comment #16 from Andre Miranda <[email protected]> ---
@Alex from the upstream bug we can conclude that we cannot blindly trust
G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE, not really gio or gvfs' fault because they
depend on third party components that may be flawed.

Removing that check now Thunar just fails telling/asking "Permission denied. Do
you want to skip? Retry | Yes to all | Yes | Cancel". Reading git history I
learned that those checks were introduced by fixing Bug 5658, which asked only
to check free space on FS. I guess those checks are meant to tell the user
exactly why the operation failed.

The options I see:
1) Remove only the G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE check. If the FS is
read-only Thunar will fail with a generic message, the user will need to find
out why, but now we are free of false positives.
2) Skip that only for remote FS with G_FILE_ATTRIBUTE_FILESYSTEM_REMOTE
(untested).

I would go with option #1, what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[email protected]
https://mail.xfce.org/mailman/listinfo/xfce-bugs

Reply via email to