https://bugzilla.xfce.org/show_bug.cgi?id=15873
--- Comment #8 from Igor <f2...@yandex.ru> --- Hi Ruben, my bad, I overlooked that the check actually looks for a failed condition. :( Since xfce_message_dialog_new() does allow NULL parent, I think your function should allow it, too. Another question is what value should be returned in the failure scenario: g_return_val_if_fail (parent == NULL || GTK_IS_WINDOW (parent), 0); Currently, 0 is returned; however, GtkResponseType enum doesn't define any response as 0 - "GTK+ leaves values of 0 or greater for application-defined response ids." (see https://developer.gnome.org/gtk3/stable/GtkDialog.html#GtkResponseType) -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
