https://bugzilla.xfce.org/show_bug.cgi?id=16516
--- Comment #9 from alexxcons <[email protected]> --- (In reply to Theo Linkspfeifer from comment #8) > > You switched from "lesss than" to "greater than" for a special reason ? > The loop now goes in the other direction (node = node->next). Uh, I somehow failed toseee that there was "->prev" before > > Think that loop can be done with only one "node" variable: > That was my initial plan, but there were corner cases. When a volume is > added to the list, the loop will break after finding the Network node > (item->device == NULL). Therefore, the new entry will be added below the > Network one -> wrong. I see ... though I at least would rename "node2" to something like "node_iter". Besides that, I think it is good to get pushed. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Xfce-bugs mailing list [email protected] https://mail.xfce.org/mailman/listinfo/xfce-bugs
