https://bugzilla.xfce.org/show_bug.cgi?id=16566
--- Comment #3 from alexxcons <[email protected]> --- More readable now, and you found a better location for the tooltips of home/desktop/computer. Nice ! Something here looks fishy: if (G_LIKELY (file != NULL)) { if (shortcut->device != NULL) { shortcut->tooltip = g_file_get_uri (file); g_object_unref (file); } else { parse_name = g_file_get_parse_name (file); shortcut->tooltip = g_markup_escape_text (parse_name, -1); g_free (parse_name); } } Before your patch, "file" was not freed at all, Now it is only is freed in the "if" case. If that is on purpose, a comment would be good. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Xfce-bugs mailing list [email protected] https://mail.xfce.org/mailman/listinfo/xfce-bugs
