https://bugzilla.xfce.org/show_bug.cgi?id=16654
--- Comment #24 from Reuben Green <[email protected]> --- Created attachment 9828 --> https://bugzilla.xfce.org/attachment.cgi?id=9828&action=edit patch to add null checks So here's a patch to fix another bug on ReplaceGtkAction45. To reproduce the bug: open a second tab (e.g Ctrl^t), go up to the parent directory in that tab, then switch back to the original tab. On my system this produces four thunar-CRITICAL warnings from thunar_standard_view_append_menu_item, followed by a segfault. The problem seems to be that the functions thunar_window_create_xxx_menu assume window->view is not NULL, but it might be. This patch adds checks to deal with this. I've given it a quick test and it does not seem to break any menu functionality that I can see. Also on my system, doing things such as changing the view or clicking into a sub directory generate warnings of the form (thunar:21309): GLib-GObject-CRITICAL **: 18:25:24.058: g_object_unref: assertion 'G_IS_OBJECT (object)' failed From some very quick investigations, these all seem to be caused by the call to gtk_menu_item_set_submenu in thunar_window_create_file_menu, but I have not got any further than that. Thanks! -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Xfce-bugs mailing list [email protected] https://mail.xfce.org/mailman/listinfo/xfce-bugs
