https://bugzilla.xfce.org/show_bug.cgi?id=16763
--- Comment #22 from Guido Falsi <[email protected]> --- (In reply to Landry Breuil from comment #20) > i dont really understand the following justification for 8 value in the > freebsd patch: > > + * An arbitrary number of keys may generate the same keyval. Rather than > add > + * memory allocation to this path, I just constrained the unmapping > behavior > + * to 8 identically coded keys. It seems unlikely? But I am no xkeyboard > + * expert. > > that means 'one will probably not remap more than 8 physical keys to the > same keycode', right ? in that case, i think it makes sense somehow.. [email protected], who originally created the patch (I only did minor changes and submitted it) can correct me if I'm wrong. He knows better for sure. I understand that comment and the code the way you do. But if strictly required the patch can be modified with memory allocation for the buffer, it looks a little overkill though. I posted cem patch almost as is, but I am open to suggestions and requests to make it better. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Xfce-bugs mailing list [email protected] https://mail.xfce.org/mailman/listinfo/xfce-bugs
