On Mon, 2008-08-18 at 10:32 +0200, Nick Schermer wrote:
> 2008/8/18 Jean-François Wauthy <[EMAIL PROTECTED]>:
> > On Thu, 2008-08-14 at 14:33 +0300, Jari Rahkonen wrote:
> >
> >> +    if(value && value != "") {
> >
> > FYI, you're comparing pointers here.
> > strlen (value) > 0 would be better IMO.
> 
> Is strlen NULL safe then?
> 
value won't be NULL since the full if condition is
if (value && strlen(value) > 0)

> if (value && *value != '\0') is also a good way to check if the string
> is 'empty'.

Yours should be more efficient since it will avoid a function call.
-- 
Jean-François Wauthy <[EMAIL PROTECTED]>

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xfce-i18n mailing list
[email protected]
http://foo-projects.org/mailman/listinfo/xfce-i18n

Reply via email to